Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buff Thaumium Reinforced Jar recipe #3125

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Gofer2x
Copy link

@Gofer2x Gofer2x commented Sep 8, 2024

The Thaumium Reinforced Jar has quadruple capacity compared to a normal one, but cannot be picked up while full. This makes it useful for making stationary setups like smelteries more compact.
But its cost makes it extremely expensive to make even a few, and it's gated by titanium - which is also what gates essentia AE2 which obsoletes jars for majority of cases.
This PR changes the recipe to be way more reasonable and ungated, but still thaumium-hungry so they can't be spammed like the cheap normal jars (if you do enough smelting to need them, you can afford them). Also uses managlass for bit of crossmod magic.
Current recipe:
image
New recipe:
image

@boubou19 boubou19 added the Affects Balance Change affecting balance. Requires admin approval before merging. label Sep 8, 2024
Copy link
Member

@Dream-Master Dream-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No wait . Titanium might a bit high but tier it from ev to lv ?

@Dream-Master
Copy link
Member

Aspects are are a joke now. From was it before

@Ruling-0
Copy link
Contributor

Ruling-0 commented Sep 8, 2024

No wait . Titanium might a bit high but tier it from ev to lv ?

As was mentioned, this requiring titanium made it useless. It provides 4x the capacity of a normal jar. For comparison, the essentia reservoir also stores 256 essentia, but of multiple types (sometimes useful sometimes not) and cannot be interacted with using phials. The reservoir requires infusion and void metal, a bit of a higher magic gate, which is fair given its extra usefulness in storing multiple types + rotation. However, this solidly places it MV-HV, which is before the old recipe. Within the thaum tiering alone it was useless.

However, titanium also unlocks AE and leads to essentia cells, which store way more than any jar, so why would you bother crafting this jar when you can instead use essentia cells? There was no purpose to this being an EV gated recipe. Being LV gives it actual purpose.

@boubou19
Copy link
Member

boubou19 commented Sep 8, 2024

Aspect wise, most of the previous ones werent making sense as it's too much for something that is barely relevant in the pack progression. I guess we can put back one or two like tutamen and vacous, or add them all back but reducing the amount of them.

Right now, this has little to no place in the pack progression because you can have the Essentia Reservoir at HV, and Thaumic Energistics unlocks in EV. Given you don't start much toying with essentias until you have the infusion matrix which requires HV for the eye of ender. If you put harder materials in the recipe, players will just skip this and go to the reservoir.

the recipe of the reservoir
image

@Alastors
Copy link
Contributor

Alastors commented Sep 8, 2024

I agree with Boubou, as it currently stands the Thaumium Jar is a fucking joke and there’s no reason to use it, like I’ve been saying this needs to be below the reservoir which means it needs to be pre infusion, otherwise, like boubou said, why would they ever use the thaumium jar when it’s the same size as the reservoir but can only store a single aspect

Copy link
Contributor

@Alastors Alastors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to happen, frankly even this is a bit too expensive IMO for how useful this jar will be considered by people, it’s merely 4x bigger than a normal jar and can’t be picked up with essentia in it, so at that rate why not just use 4x more normal jars for a fraction of the price.

@chochem chochem added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Sep 8, 2024
@Dream-Master
Copy link
Member

Will edit it later

@Dream-Master
Copy link
Member

I not forgot about this and will edit it as soon I have time for it.

@Dream-Master
Copy link
Member

Dream-Master commented Sep 24, 2024

i check the orginal recipe from old Kekztech code and it was a infusion recipe
https://github.com/GTNewHorizons/KekzTech/blob/master/src/main/java/common/Researches.java#L25-L46

    public static void postInit() {
        final AspectList aspects_jarthaumiumreinforced = new AspectList().add(Aspect.ARMOR, 3)
            .add(Aspect.WATER, 3)
            .add(Aspect.GREED, 3)
            .add(Aspect.VOID, 3);
        @SuppressWarnings("unused")
        final ResearchItem jar_thaumiumreinforced = new ResearchItem(
            "THAUMIUMREINFORCEDJAR",
            "ALCHEMY",
            aspects_jarthaumiumreinforced,
            3,
            -4,
            2,
            new ItemStack(Blocks.jarThaumiumReinforced, 1))
                .setPages(
                    new ResearchPage("kekztech.research_page.THAUMIUMREINFORCEDJAR.0"),
                    new ResearchPage(Recipes.infusionRecipes.get("THAUMIUMREINFORCEDJAR")),
                    new ResearchPage(Recipes.infusionRecipes.get("THAUMIUMREINFORCEDVOIDJAR")),
                    new ResearchPage("kekztech.research_page.THAUMIUMREINFORCEDJAR.1"))
                .setConcealed()
                .setParents("JARLABEL")
                .registerResearchItem();```

@Dream-Master
Copy link
Member

Dream-Master commented Sep 24, 2024

and it used titanium as well
https://github.com/GTNewHorizons/KekzTech/blob/master/src/main/java/common/Recipes.java#L55C1-L81C48

        // Thaumium Reinforced Jar
        final ItemStack[] recipe_jarthaumiumreinforced = {
            GameRegistry.makeItemStack("Thaumcraft:ItemResource", 15, 1, null),
            GT_OreDictUnificator.get(OrePrefixes.plateDense, Materials.Thaumium, 1),
            new ItemStack(net.minecraft.init.Blocks.glass_pane),
            GT_OreDictUnificator.get(OrePrefixes.plateDense, Materials.Thaumium, 1),
            new ItemStack(net.minecraft.init.Blocks.glass_pane),
            GT_OreDictUnificator.get(OrePrefixes.frameGt, Materials.Titanium, 1),
            GT_OreDictUnificator.get(OrePrefixes.plateDense, Materials.Thaumium, 1),
            new ItemStack(net.minecraft.init.Blocks.glass_pane),
            GT_OreDictUnificator.get(OrePrefixes.plateDense, Materials.Thaumium, 1),
            new ItemStack(net.minecraft.init.Blocks.glass_pane), };
        final AspectList aspects_jarthaumiumreinforced = new AspectList().add(Aspect.ARMOR, 64)
            .add(Aspect.ORDER, 32)
            .add(Aspect.WATER, 32)
            .add(Aspect.GREED, 16)
            .add(Aspect.VOID, 16)
            .add(Aspect.AIR, 8);
        infusionRecipes.put(
            "THAUMIUMREINFORCEDJAR",
            ThaumcraftApi.addInfusionCraftingRecipe(
                "THAUMIUMREINFORCEDJAR",
                new ItemStack(Blocks.jarThaumiumReinforced, 1, 0),
                5,
                aspects_jarthaumiumreinforced,
                ItemApi.getBlock("blockJar", 0),
                recipe_jarthaumiumreinforced));```

@Alastors
Copy link
Contributor

and it used titanium as well https://github.com/GTNewHorizons/KekzTech/blob/master/src/main/java/common/Recipes.java#L55C1-L81C48

        // Thaumium Reinforced Jar
        final ItemStack[] recipe_jarthaumiumreinforced = {
            GameRegistry.makeItemStack("Thaumcraft:ItemResource", 15, 1, null),
            GT_OreDictUnificator.get(OrePrefixes.plateDense, Materials.Thaumium, 1),
            new ItemStack(net.minecraft.init.Blocks.glass_pane),
            GT_OreDictUnificator.get(OrePrefixes.plateDense, Materials.Thaumium, 1),
            new ItemStack(net.minecraft.init.Blocks.glass_pane),
            GT_OreDictUnificator.get(OrePrefixes.frameGt, Materials.Titanium, 1),
            GT_OreDictUnificator.get(OrePrefixes.plateDense, Materials.Thaumium, 1),
            new ItemStack(net.minecraft.init.Blocks.glass_pane),
            GT_OreDictUnificator.get(OrePrefixes.plateDense, Materials.Thaumium, 1),
            new ItemStack(net.minecraft.init.Blocks.glass_pane), };
        final AspectList aspects_jarthaumiumreinforced = new AspectList().add(Aspect.ARMOR, 64)
            .add(Aspect.ORDER, 32)
            .add(Aspect.WATER, 32)
            .add(Aspect.GREED, 16)
            .add(Aspect.VOID, 16)
            .add(Aspect.AIR, 8);
        infusionRecipes.put(
            "THAUMIUMREINFORCEDJAR",
            ThaumcraftApi.addInfusionCraftingRecipe(
                "THAUMIUMREINFORCEDJAR",
                new ItemStack(Blocks.jarThaumiumReinforced, 1, 0),
                5,
                aspects_jarthaumiumreinforced,
                ItemApi.getBlock("blockJar", 0),
                recipe_jarthaumiumreinforced));```

Look man, as long as this is MV, I genuinely don't care about the specifics, it just needs to be tiered before the reservoir and after the normal jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects Balance Change affecting balance. Requires admin approval before merging. ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants